Migration test #473
Merged
Migration test #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jan 19, 2023
|
|
||
| it('migrates down', async () => { | ||
| await db.migrator.migrateDown() | ||
| await expect(getHistory()).rejects.toThrow() |
There was a problem hiding this comment.
This line is responsible for the CI failure:
@atproto/pds: FAIL tests/migrations/repo-sync-data.test.ts (9.414 s)
@atproto/pds: ● repo sync data migration › migrates down
@atproto/pds: expect(received).rejects.toThrow()
@atproto/pds: Received function did not throw
@atproto/pds: 54 | it('migrates down', async () => {
@atproto/pds: 55 | await db.migrator.migrateDown()
@atproto/pds: > 56 | await expect(getHistory()).rejects.toThrow()
devinivy
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a relatively easy migration to check that it went well.
Instead of the somewhat contrived test I was doing earlier, I just fill the db with sample data, migrate down (delete both tables), migrate up & ensure that the data matches